Make buildSetCookieHeaderFromBrowserCookie robust #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The computer is sad |
szepeviktor
commented
Oct 23, 2024
@szepeviktor Next time please a little more information what you're trying to say...what the comment is about. I guess it's from running tests locally on your machine? 🤔 Not sure what's going on there...they're working on my machine as well as in gh actions. |
|
It was here on GitHub. One of the workflows failed.
https://github.com/crwlrsoft/crawler/actions/runs/11473029647/job/31926578720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can clearly see what is going on in
buildSetCookieHeaderFromBrowserCookie.Review:
crawler/src/Loader/Http/Cookies/CookieJar.php
Line 124 in f0da585