Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy-pasta in CookieJar #168

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix copy-pasta in CookieJar #168

merged 1 commit into from
Oct 22, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Oct 21, 2024 •
edited
Loading

@otsch Here we go! 🍪

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 21, 2024 •
edited
Loading

This may be 2.0 of that method.

function buildRequestCookie()
{
    $headers = [
        sprintf('%s=%s', $cookie->getName(), $cookie->getValue()),
        $cookie->convert('expires', 'Expires'),
        $cookie->convert('max-age', 'Max-Age'),
        // ...
    ];

    return implode('; ', array_filter($headers));
}

@otsch
Copy link
Member

otsch commented Oct 22, 2024

Oh, wow, thx a lot! Will add better test cases for this!

@otsch otsch merged commit 83aa71a into crwlrsoft:main Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @otsch