disable multiplexing for some versions of curl#12207
Merged
Seldaek merged 2 commits intocomposer:mainfrom Nov 25, 2024
Merged
Conversation
Contributor
Author
|
A more readable version of the backported code can be found here : https://github.com/rust-lang/cargo/blob/88edf01fe39d6d15c8e15dbf4ea478661b7b85e3/src/cargo/util/context/mod.rs#L2983-L3009. |
Contributor
Author
|
Okay, the option needs to be set on the CurlMultiHandle (and not the CurlHandle). I'll think about how to do it. A quick & dirty test on my corporate environment showed that it did fix my issue. |
I'm behind a corporate proxy and was hitting a `Curl 2 (...) [CONN-1-0] send: no filter connected` error when trying to download some packages. Some google research led me to rust-lang/cargo#12202 and its fix rust-lang/cargo#12234. This PR backports this fix to composer. > In certain versions of libcurl when proxy is in use with HTTP/2 multiplexing, connections will continue stacking up. This was fixed in libcurl 8.0.0 in curl/curl@821f6e2
Lctrs
force-pushed
the
fix/proxy/no-multiplexing-bad-curl
branch
from
827b895 to
5dbea92
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm behind a corporate proxy and was hitting a
Curl 2 (...) [CONN-1-0] send: no filter connectederror when trying to download some packages.Some google research led me to rust-lang/cargo#12202 and its fix rust-lang/cargo#12234.
This PR backports this fix to composer.