Skip to content

mgr/dashboard: fix host form issues #60799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

mgr/dashboard: fix host form issues #60799

merged 1 commit into from
Feb 9, 2025
+28 −22

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Nov 22, 2024 •
edited
Loading

Addressing the review comments in #60355 (review)

Issues fixing

  • cluster expansion host form not closing form when submitting it
  • cluster expansion host form changing the location when closing it
  • put the helper text inside helper component since its longer
  • maintenance field should be hidden in cluster expansion form since its not a valid option while expanding a cluster. We already add host in _no_schedule
blob.8.mp4

Fixes: https://tracker.ceph.com/issues/69020

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@nizamial09 nizamial09 requested a review from a team as a code owner November 22, 2024 13:00
@cloudbehl
Copy link
Contributor

any screenshot or recording of the workflow?

@nizamial09
Copy link
Member Author

any screenshot or recording of the workflow?

@cloudbehl attached now in the description

@nizamial09 nizamial09 requested review from a team as code owners November 25, 2024 11:06
@nizamial09 nizamial09 removed request for a team November 25, 2024 11:07
nmunet
nmunet reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@nmunet nmunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nizamial09,
tested the changes, LGTM.

@nizamial09
Copy link
Member Author

There's an issue with the alignment of helper popover, which is being addressed by @pujaoshahu in a different PR. So I won't be repeating here.
image

nizamial09
nizamial09 commented Nov 25, 2024
View reviewed changes
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.html
@@ -1,7 +1,6 @@
<cds-modal size="md"
[open]="open"
[hasScrollingContent]="true"
(overlaySelected)="closeModal()">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this so that modal won't close when you click outside the modal body. Its okay for a normal modal but when the modal is routed, its not expected to close on the outside click.

@nizamial09 nizamial09 requested a review from nmunet November 26, 2024 05:12
@nizamial09
Copy link
Member Author

jenkins test make check

nmunet
nmunet approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@nmunet nmunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test make check

@github-actions GitHub Actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@nizamial09 nizamial09 force-pushed the host-form-followups branch 2 times, most recently from 18c2948 to c1b0bf1 Compare December 30, 2024 05:27
@nizamial09 nizamial09 requested a review from afreen23 December 30, 2024 05:28
@nizamial09 nizamial09 mentioned this pull request Jan 10, 2025
Merged
14 tasks
@nizamial09
Copy link
Member Author

jenkins test windows

@afreen23
Copy link
Contributor

afreen23 commented Feb 5, 2025

Hi @nizamial09 ,

This is what I am reading from carbon:
image

Hence I dont think we should be using here tooltip, the precious was fine.
And as suggested offline we need to rework the help text here perhaps.

@nizamial09
Copy link
Member Author

Hence I dont think we should be using here tooltip, the precious was fine.

i read that before and the guideline says 'information the user needs to complete the task.' but for the host form, that information is not needed for completing the form. anyways, I can go ahead and leave that as it is before.

And as suggested offline we need to rework the help text here perhaps.

is it okay if i open a separate PR to do that? The jenkins is broken for a long time and this is one of the PR that intents to fix it so if we could I would really hope to finish that soon.

@nizamial09
Copy link
Member Author

@afreen23 i reverted it back to the older form btw
image

@afreen23
Copy link
Contributor

afreen23 commented Feb 5, 2025 

[lint:html    ] ERROR in /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.html
[lint:html    ] 
[lint:html    ] src/app/ceph/cluster/hosts/host-form/host-form.component.html
[lint:html    ]   18:12  File should use 2 space indentation

@nizamial09
mgr/dashboard: fix host form issues
9bc969b 
Addressing the review comments in ceph#60355 (review)

Issues fixing
 - cluster expansion host form not closing form when submitting it
 - cluster expansion host form changing the location when closing it
 - put the helper text inside helper component since its longer
 - maintenance field should be hidden in cluster expansion form since
   its not a valid option while expanding a cluster. We already add host
   in _no_schedule

Fixes: https://tracker.ceph.com/issues/69020
Signed-off-by: Nizamudeen A <[email protected]>
@nizamial09
Copy link
Member Author 

[lint:html    ] ERROR in /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.html
[lint:html    ] 
[lint:html    ] src/app/ceph/cluster/hosts/host-form/host-form.component.html
[lint:html    ]   18:12  File should use 2 space indentation

thanks @afreen23. fixed it

@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test api

@nizamial09 nizamial09 merged commit 298079e into ceph:main Feb 9, 2025
12 of 14 checks passed
@nizamial09 nizamial09 deleted the host-form-followups branch February 9, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl approved these changes

@afreen23 afreen23 afreen23 approved these changes

@nmunet nmunet nmunet approved these changes

@dnyanee1997 dnyanee1997 Awaiting requested review from dnyanee1997

Assignees
No one assigned
Labels
dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nizamial09 @cloudbehl @afreen23 @nmunet