mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard #60798

nmunet · 2024-11-22T10:11:13Z

Fixes: https://tracker.ceph.com/issues/68976

Signed-off-by: Naman Munet [email protected]

Previously: users are not able to edit the configuration which have the 'can_update_at_runtime' flag as false.
Now:

Users will be able to edit the configuration related with 'rgw' by forcefully editing the configuration if the 'can_update_at_runtime' flag is false for it.
After navigating to Administration >> Configuration, by default configuration with filter level:basic is seen

Fixes Includes:

by-passing 'can_update_at_runtime' flag for 'rgw' related configurations as the same can be updated at runtime via CLI. Also implemented a warning popup for user to make force edit to rgw related configurations.
when navigated to Administration >> Configuration, modified configuration will be seen as we see in cli "ceph config dump", instead of configuration with filter level:basic

Screencast.from.2024-11-22.15-33-23.mp4

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

nmunet · 2024-11-26T11:47:42Z

jenkins retest this please

nizamial09

@nmunet left a few comments here. overall good but there are more room for improvements. thanks

src/pybind/mgr/dashboard/controllers/cluster_configuration.py

...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.html

nizamial09

Looks good to me, thank you @nmunet

...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.html

...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.scss

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts

nizamial09 · 2024-11-29T03:57:24Z

jenkins test make check

nizamial09 · 2024-11-29T03:57:32Z

jenkins test api

nizamial09 · 2024-11-29T03:57:39Z

jenkins test submodules

nizamial09 · 2024-11-29T03:57:52Z

jenkins test dashboard

nmunet · 2024-12-02T10:32:12Z

jenkins test api

nmunet · 2024-12-02T10:32:18Z

jenkins test dashboard

nmunet · 2024-12-02T11:56:34Z

jenkins test api

nmunet · 2024-12-03T04:35:54Z

jenkins test api

nmunet · 2024-12-03T10:56:42Z

jenkins test api

nmunet · 2024-12-06T12:14:09Z

jenkins test api

nmunet · 2024-12-06T12:14:15Z

jenkins test dashboard

nmunet · 2024-12-06T12:14:27Z

jenkins test windows

nmunet · 2024-12-09T05:40:43Z

jenkins test api

nmunet · 2024-12-09T06:55:05Z

jenkins test api

nmunet · 2024-12-10T09:56:59Z

jenkins test api

nmunet · 2024-12-10T10:33:16Z

jenkins test windows

afreen23

Please fix the signed-off commit, thanks.

This is a good improvement, thanks 👍🏿

qa/tasks/mgr/dashboard/test_rbd.py

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts

...ontend/src/app/ceph/cluster/configuration/configuration-form/configuration-form.component.ts

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts

nmunet · 2024-12-16T13:52:07Z

jenkins test make check

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts

…tions are not updatable at runtime Fixes: https://tracker.ceph.com/issues/68976 Fixes Includes: 1) by-passing 'can_update_at_runtime' flag for 'rgw' related configurations as the same can be updated at runtime via CLI. Also implemented a warning popup for user to make force edit to rgw related configurations. 2) when navigated to Administration >> Configuration, modified configuration will be seen as we see in cli "ceph config dump", instead of configuration with filter level:basic Signed-off-by: Naman Munet <[email protected]>

nmunet · 2024-12-17T04:50:51Z

jenkins test api

nmunet · 2024-12-17T04:51:00Z

jenkins test make check

afreen23

Non blocking comments but good for maintenance.

afreen23 · 2024-12-17T07:53:45Z

...ontend/src/app/ceph/cluster/configuration/configuration-form/configuration-form.component.ts

+import { CriticalConfirmationModalComponent } from '~/app/shared/components/critical-confirmation-modal/critical-confirmation-modal.component';
+import { ModalCdsService } from '~/app/shared/services/modal-cds.service';
+
+const RGW = 'rgw';


We dont need to define same constant in both files.
We can move it to a generic file and call from that to both places.

This is for normal housekeeping (not blocking PR)

will work on these changes in my next PR related to configuration, as we have more work to do here!
Thanks

afreen23 · 2024-12-17T07:54:24Z

...ontend/src/app/ceph/cluster/configuration/configuration-form/configuration-form.component.ts

@@ -118,7 +123,7 @@ export class ConfigurationFormComponent extends CdForm implements OnInit {
        this.configForm.get('values').get(value.section).setValue(sectionValue);
      });
    }
-
+    this.forceUpdate = !this.response.can_update_at_runtime && response.name.includes(RGW);


Perhaps add a generic helper function and move this alongwith the constant in a generic file calling at both places.

Suggested change

this.forceUpdate = !this.response.can_update_at_runtime && response.name.includes(RGW);

this.forceUpdate = !this.response.can_update_at_runtime && hasRGW(response.name);

afreen23 · 2024-12-17T07:55:02Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts

@@ -143,7 +145,9 @@ export class ConfigurationComponent extends ListWithDetails implements OnInit {
    if (selection.selected.length !== 1) {
      return false;
    }
-
-    return selection.selected[0].can_update_at_runtime;
+    if ((this.selection.selected[0].name as string).includes(RGW)) {


Suggested change

if ((this.selection.selected[0].name as string).includes(RGW)) {

if (hasRGW(this.selection.selected[0].name)) {

nmunet requested a review from a team as a code owner November 22, 2024 10:11

nmunet requested review from dnyanee1997 and Achintk1491 and removed request for a team November 22, 2024 10:11

github-actions bot added dashboard pybind labels Nov 22, 2024

nmunet requested review from aaSharma14 and nizamial09 and removed request for aaSharma14 November 22, 2024 10:11

nmunet force-pushed the edit-configuration-at-runtime branch from 915b4d1 to 13eb9f0 Compare November 25, 2024 10:53

github-actions bot added the api-change label Nov 25, 2024

nmunet force-pushed the edit-configuration-at-runtime branch from 13eb9f0 to d8f4b4e Compare November 26, 2024 07:09

nizamial09 requested changes Nov 26, 2024

View reviewed changes

nmunet force-pushed the edit-configuration-at-runtime branch from d8f4b4e to 986ecaf Compare November 27, 2024 11:00

nizamial09 approved these changes Nov 27, 2024

View reviewed changes

nmunet force-pushed the edit-configuration-at-runtime branch from 986ecaf to 923758c Compare November 28, 2024 07:18

nmunet force-pushed the edit-configuration-at-runtime branch 2 times, most recently from 3c73d49 to a25916c Compare December 5, 2024 13:31

github-actions bot added the tests label Dec 5, 2024

nmunet force-pushed the edit-configuration-at-runtime branch from a25916c to d80872f Compare December 6, 2024 05:35

nmunet force-pushed the edit-configuration-at-runtime branch from d80872f to f3ca718 Compare December 6, 2024 07:27

nmunet force-pushed the edit-configuration-at-runtime branch from f3ca718 to ebe7ebc Compare December 6, 2024 12:16

nmunet force-pushed the edit-configuration-at-runtime branch from ebe7ebc to a0d7c87 Compare December 10, 2024 06:32

nmunet requested a review from nizamial09 December 10, 2024 12:09

nizamial09 approved these changes Dec 12, 2024

View reviewed changes

afreen23 requested changes Dec 13, 2024

View reviewed changes

nmunet force-pushed the edit-configuration-at-runtime branch 2 times, most recently from 3e13e0e to b559501 Compare December 16, 2024 08:24

afreen23 approved these changes Dec 16, 2024

View reviewed changes

nmunet force-pushed the edit-configuration-at-runtime branch from b559501 to 4bb9c7f Compare December 16, 2024 09:57

afreen23 requested changes Dec 16, 2024

View reviewed changes

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration.component.ts Outdated Show resolved Hide resolved

nmunet force-pushed the edit-configuration-at-runtime branch from 4bb9c7f to 3181acc Compare December 16, 2024 16:21

afreen23 reviewed Dec 17, 2024

View reviewed changes

afreen23 approved these changes Dec 17, 2024

View reviewed changes

afreen23 merged commit 744eb5c into ceph:main Dec 17, 2024
12 of 14 checks passed

afreen23 deleted the edit-configuration-at-runtime branch December 17, 2024 08:09

This was referenced Dec 26, 2024

Squid: mgr/dashboard: Administration > Configuration > Some of the config options are not updatable at runtime #61181

Merged

reef: mgr/dashboard: Administration > Configuration > Some of the config options are not updatable at runtime #61182

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard #60798

mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard #60798

nmunet commented Nov 22, 2024 •

edited

Loading

nmunet commented Nov 26, 2024

nizamial09 left a comment

nizamial09 left a comment

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 3, 2024

nmunet commented Dec 3, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 9, 2024

nmunet commented Dec 9, 2024

nmunet commented Dec 10, 2024

nmunet commented Dec 10, 2024

afreen23 left a comment

nmunet commented Dec 16, 2024

nmunet commented Dec 17, 2024

nmunet commented Dec 17, 2024

afreen23 left a comment

afreen23 Dec 17, 2024

nmunet Dec 17, 2024

afreen23 Dec 17, 2024

afreen23 Dec 17, 2024

	this.forceUpdate = !this.response.can_update_at_runtime && response.name.includes(RGW);
	this.forceUpdate = !this.response.can_update_at_runtime && hasRGW(response.name);

	if ((this.selection.selected[0].name as string).includes(RGW)) {
	if (hasRGW(this.selection.selected[0].name)) {

mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard #60798

mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard #60798

Conversation

nmunet commented Nov 22, 2024 • edited Loading

Contribution Guidelines

Checklist

nmunet commented Nov 26, 2024

nizamial09 left a comment

Choose a reason for hiding this comment

nizamial09 left a comment

Choose a reason for hiding this comment

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nizamial09 commented Nov 29, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 2, 2024

nmunet commented Dec 3, 2024

nmunet commented Dec 3, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 6, 2024

nmunet commented Dec 9, 2024

nmunet commented Dec 9, 2024

nmunet commented Dec 10, 2024

nmunet commented Dec 10, 2024

afreen23 left a comment

Choose a reason for hiding this comment

nmunet commented Dec 16, 2024

nmunet commented Dec 17, 2024

nmunet commented Dec 17, 2024

afreen23 left a comment

Choose a reason for hiding this comment

afreen23 Dec 17, 2024

Choose a reason for hiding this comment

nmunet Dec 17, 2024

Choose a reason for hiding this comment

afreen23 Dec 17, 2024

Choose a reason for hiding this comment

afreen23 Dec 17, 2024

Choose a reason for hiding this comment

nmunet commented Nov 22, 2024 •

edited

Loading