Skip to content

cephfs-top: add mount point type as one of the field in cephfs-top #60790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cephfs-top: add mount point type as one of the field in cephfs-top #60790

wants to merge 1 commit into from

Conversation

neesingh-rh
Copy link
Contributor

@neesingh-rh neesingh-rh commented Nov 21, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/69000
Signed-off-by: Neeraj Pratap Singh [email protected]

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@neesingh-rh neesingh-rh requested a review from a team as a code owner November 21, 2024 12:53
@github-actions github-actions bot added cephfs Ceph File System documentation labels Nov 21, 2024
@neesingh-rh neesingh-rh force-pushed the wip-add-mount-info-in-cephfs-top branch from 14f73f4 to 12f20cf Compare November 21, 2024 12:54
@neesingh-rh
Copy link
Contributor Author

jenkins retest this please

@neesingh-rh neesingh-rh requested a review from a team November 27, 2024 04:48
@neesingh-rh
Copy link
Contributor Author

jenkins test make check arm64

@neesingh-rh neesingh-rh requested a review from joscollin December 9, 2024 05:04
@joscollin joscollin removed their request for review December 9, 2024 05:14
joscollin
joscollin requested changes Jan 13, 2025
View reviewed changes
vshankar
vshankar reviewed Jan 13, 2025
View reviewed changes
src/tools/cephfs/top/cephfs-top
@@ -184,6 +186,14 @@ class FSTopBase(object):
elif item == FS_TOP_MAIN_WINDOW_COL_MNT_ROOT:
client_id_meta.update({item:
client_meta[CLIENT_METADATA_MOUNT_ROOT_KEY]})
elif item == FS_TOP_MAIN_WINDOW_COL_MNTPT_TYPE:
if "kernel_version" in client_meta:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older kernel do not advertise kernel_version in client metadata, so with this logic they would get reported as libcephfs clients :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we giving the number of kernel clients with this same way? https://github.com/ceph/ceph/blob/main/src/tools/cephfs/top/cephfs-top#L268 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How old are the kernels? Does libcephfs have any of its own special metadata, or formatting we can use, to disambiguate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neesingh-rh Have you checked regarding @gregsfortytwo comment? cephfs-top might be reporting incorrect libcephfs clients if older kernel clients are using the file system.

@neesingh-rh neesingh-rh force-pushed the wip-add-mount-info-in-cephfs-top branch from 12f20cf to d87dba8 Compare January 13, 2025 10:18
joscollin
joscollin approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

@neesingh-rh
Copy link
Contributor Author

jenkins retest this please

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 15, 2025
@neesingh-rh
Copy link
Contributor Author

jenkins retest this please

@github-actions github-actions bot removed the stale label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar left review comments

@gregsfortytwo gregsfortytwo gregsfortytwo left review comments

@joscollin joscollin joscollin approved these changes

Assignees

@joscollin joscollin

Labels
cephfs Ceph File System documentation needs-qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neesingh-rh @vshankar @gregsfortytwo @joscollin