-
-
Notifications
You must be signed in to change notification settings - Fork 637
Not just another custom column widths PR #715
base: master
Are you sure you want to change the base?
Conversation
…m column widths through writer or OptionsManager (and test for it)
…ow height for XLSX
…mn-widths # Conflicts: # src/Spout/Writer/XLSX/Manager/WorksheetManager.php
Verified that @aphofstede has signed the CLA. Thanks for the pull request! |
@adrilo Did you notice this one? Thanks! |
Hi, how could I have this code on my composer vendor directory ? I do need also to resize columns |
Found you delayed the Fixed this issue by moving the bool that the records if the I have refactored See: aphofstede#1 |
Is this gonna be merged soon ? I was gonna work on the same issue. |
Any updates? When will this be merged? |
Use options manager for default row height and column width
Thanks @mawi12345 - I merged your fixes. Any chance we can get this merged into master? |
@mawi12345 Could you sign the CLA as well? |
@mawi12345 Sloppy of me to not check first, but it looks like your PR broke some tests, could your PR a fix for those? Thanks. |
The main contributor of this project (@adrilo) has parted ways with Box and so lost admin access to the repo and could no longer release new versions for quite a while. He seems to be back though so fingers crossed. See: #754 (comment) |
Please merge with the changes in the master due to the
warning (if @adrilo would accept such a PR). |
# Conflicts: # src/Spout/Writer/ODS/Manager/WorksheetManager.php # src/Spout/Writer/XLSX/Manager/WorksheetManager.php
@adrilo Fixed conflicts. |
@adrilo Any chance this might get merged anytime soon? Would love to have it mainline. |
Please merge |
@adrilo Merged master into this one again. Please review? |
Pull request started end of 2019, now it's middle of 2021. Any news on this, why such a feature is not merged? |
Is the source still developing? |
Please merge |
Please, merge! |
Merge this please. |
Cool! Let's merge this PR! |
Is the project dead? |
@adrilo has been active recently, but haven't heard any comments on this. |
The project is not totally dead, but I have very little time to work on it these days... So I would not expect big changes in the near future. |
@aphofstede While PR is still open, would you like to add |
2019 pull request still open 3 years later? Totally dead |
Can we help in some way? Do we all need to open a GoFundMe, can I chip in some budget for development time? Because what I know see is that the main branch has been updated with PHPCS / PHP Stan etc, to the merge probaly won't go through. @aphofstede fixed the merged conflicts, but then again it diverded to far from main that it couldn't get merged. If we can come up with a time-frame, person X fixes merge conflicts, and then someone with merge rights to finish the merge. That would also be ok, just let me know. I can find some time in March / April to look at the merge conflicts? If it's lack of time because it's not paid work, then we can look for some option to provided the budget. Looking at this enough people would like to see this one go through. I just put action to my words and am Sponsering this project https://github.com/sponsors/adrilo, throughout my freelance company. If you all who are using this in a paid project just chip in 1 hour worth of development time. This PR can land, but only if we all support Open Source by chipping time or sponsering, we can't expect this to be fixed for free. Come on everyone, we can make this work. |
I'd gladly fix any merge conflicts again for this to go in, but am hesitant to spend the time before a confirmation from a maintainer that this will then be merged. (Which probably means them reviewing the code, at least superficially) |
@aphofstede this package license is permissive: https://choosealicense.com/licenses/apache-2.0/ Box is a company, I vote for a community driven fork: I give my availability to maintain it across active PHP versions. If you step in with me, we can start it today; @adrilo will be invited as a maintainer too |
Merged in openspout/openspout#4 |
This may be the best move to see all these PRs get through. I am aiming for a high level of quality (code structure, tests, documentation, internationalization...) and have extra requirements such as having similar features added for both XLSX and ODS. The drawback is that each new feature requires a lot of things and needs attention. Given my lack of time, it makes it very hard to review and merge such features. Good luck with this fork, I'm happy if it helps! |
@adrilo you have been invited in @openspout as a maintainer. I am already used to package maintenance and quality code base (see i.e. But your experience on the topic is invaluable, like for example #617 (comment), so I'd really appreciate if you can accept the invitation: you can drop your review on the core issues and ideas, and I'll manage the rest 😉 |
Adds support for setting default row height, default column width and custom column widths configuration.
Fixes #118, among others.
I checked what other PRs had been created to fix this and the objections in the conversations there. Hopefully this fits your standards.
Things to note:
Known issues: