Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Formula support #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Formula support #612

wants to merge 1 commit into from

Conversation

elibyy
Copy link

@elibyy elibyy commented Jan 3, 2019

Hey there,
I always needed the formula in my reports, so I've made an implementation of that, And it would be nice to have it within the original package.

P.S. Really needed that on production ASAP so had to change the composer package, if this causes a problem with the PR, I can fork to different repo

Thanks
Eli

barryvdh
barryvdh reviewed Jan 29, 2019
View reviewed changes
composer.json Outdated
@@ -1,5 +1,5 @@
{
"name": "box/spout",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be changed in your PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as being said I needed this in prod, so I'll commit another with the correct package name

@barryvdh
Copy link

So basically, this sets the formula without calculation it, right? So it wouldn't affect performance (much)?

Looks nice. Similar to #425 but this allows to set the pre-calculated value, which is nice :)

@elibyy
Copy link
Author

elibyy commented Jan 29, 2019

This ia based on that PR but with two changes

  1. There's a class and not just guessing by equals sign
  2. You can set the pre calculated value so if the user opens it in excel without enabling editing they would still have a value

@barryvdh barryvdh mentioned this pull request Jan 29, 2019
Open
@barryvdh
Copy link

Should this be targeted at the v3 branch? As that is coming soon(ish) as it seems?

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidbonting davidbonting mentioned this pull request Feb 21, 2022
Open
@Slamdunk Slamdunk mentioned this pull request Mar 2, 2022
Merged
@Slamdunk
Copy link

Slamdunk commented Mar 2, 2022

Merged a variation in openspout/openspout#5

jeremyjumeau pushed a commit to jeremyjumeau/spout that referenced this pull request Apr 29, 2022
feat() formula support see box#612
a838c92
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barryvdh barryvdh barryvdh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elibyy @barryvdh @CLAassistant @Slamdunk @eli-amazing