fix r cmd check warning on use of bitwise &

bnosac · Mar 23, 2022 · a8c053c · a8c053c
1 parent b1c9a72
commit a8c053c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: udpipe
 Type: Package
 Title: Tokenization, Parts of Speech Tagging, Lemmatization and Dependency
     Parsing with the 'UDPipe' 'NLP' Toolkit
-Version: 0.8.8
+Version: 0.8.9
 Maintainer: Jan Wijffels <[email protected]>
 Authors@R: c(
     person('Jan', 'Wijffels', role = c('aut', 'cre', 'cph'), email = '[email protected]'), 

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+## CHANGES IN udpipe VERSION 0.8.9
+
+- fix R CMD check message on Fedora clang infrastructure: rcpp_udpipe.cpp:243:8: warning: use of bitwise '&' with boolean operands
+
 ## CHANGES IN udpipe VERSION 0.8.8
 
 - dtm_svd_similarity, fix to make sure that if provided a dtm with features which are all missing/zero, 

diff --git a/src/rcpp_udpipe.cpp b/src/rcpp_udpipe.cpp
@@ -240,7 +240,7 @@ Rcpp::List udp_tokenise_tag_parse_basic(SEXP udmodel, Rcpp::StringVector x, Rcpp
 Rcpp::CharacterVector na_locf(Rcpp::CharacterVector x) {
   int i;
   for(i = 1; i < x.size(); i++) {
-    if((x[i] == NA_STRING) & (x[i-1] != NA_STRING)) {
+    if((x[i] == NA_STRING) && (x[i-1] != NA_STRING)) {
       x[i] = x[i-1];
     }
   }