Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve flags parsing #461

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: improve flags parsing #461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4ab12c
fix: upgrade ffcli version v2->v3
Doozers Sep 15, 2022
a82b084
fix: upgrade moul/u version
Doozers Sep 15, 2022
42eb923
feat: implement moul/climan
Doozers Sep 15, 2022
d0ef6ca
feat: use commonFlagsBuilder as a method
Doozers Sep 15, 2022
c0c27bd
fix: apply review comments
Doozers Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: upgrade moul/u version 
Signed-off-by: ismael FALL <[email protected]>
  • Loading branch information
@Doozers
Doozers committed Sep 15, 2022
commit a82b0840bf40a11dd4d4914492095b90899ac10c
3 changes: 2 additions & 1 deletion go.mod
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions go/pkg/yolosvc/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ import (
"berty.tech/yolo/v2/go/pkg/bintray"
"berty.tech/yolo/v2/go/pkg/yolopb"
"berty.tech/yolo/v2/go/pkg/yolostore"
"go.uber.org/zap"
"moul.io/u"

"github.com/buildkite/go-buildkite/buildkite"
"github.com/google/go-github/v32/github"
"github.com/jinzhu/gorm"
"github.com/jszwedko/go-circleci"
"github.com/tevino/abool"
"go.uber.org/zap"
"moul.io/u"
)

type Service interface {
Expand Down Expand Up @@ -86,8 +87,8 @@ func NewService(db *gorm.DB, opts ServiceOpts) (Service, error) {
devMode: opts.DevMode,
clearCache: opts.ClearCache,
artifactsCachePath: opts.ArtifactsCachePath,
iosPrivkeyPath: u.MustExpandUser(opts.IOSPrivkeyPath),
iosProvPath: u.MustExpandUser(opts.IOSProvPath),
iosPrivkeyPath: u.MustExpandPath(opts.IOSPrivkeyPath),
iosProvPath: u.MustExpandPath(opts.IOSProvPath),
Doozers marked this conversation as resolved.
Show resolved Hide resolved
iosPrivkeyPass: opts.IOSPrivkeyPass,
artifactsCacheMapMutex: map[string]*sync.Mutex{},
}, nil
Expand Down