Skip to content

Commit

Permalink
feat(elasticloadbalancingv2): ip address type for both network and ap…
Browse files Browse the repository at this point in the history
…plication target group (#32189)

### Issue # (if applicable)

None

### Reason for this change

Both Application and Network target group supports for specifying IP address type.

Application: <https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-ip-address-type>
Network: <https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type>

### Description of changes

- Define `TargetGroupIpAddressType` enum
  - Because there has been a `IpAddressType` in `aws-elassticloadbalancingv2` module, I don't name `IpAddressType`
- Add `ipAddressType` prop to `BaseTargetGroupProps`

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
badmintoncryer authored Nov 26, 2024
1 parent 2eebc59 commit 7cc5f30
Show file tree
Hide file tree
Showing 26 changed files with 6,593 additions and 5 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7cc5f30

Please sign in to comment.