Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cli): assume role calls are skipping the proxy (#32291)
`STSClientConfig` and `NodeHttpHandlerOptions` are different types, but all have optional properties only. That means that a call like this: ```ts const credentials = await fromTemporaryCredentials({ masterCredentials: mainCredentials.credentials, params: { RoleArn: roleArn, ExternalId: externalId, RoleSessionName: `aws-cdk-${safeUsername()}`, ...additionalOptions, TransitiveTagKeys: additionalOptions?.Tags ? additionalOptions.Tags.map((t) => t.Key!) : undefined, }, clientConfig: { region, ...this.requestHandler, // type NodeHttpHandlerOptions }, })(); ``` compiles just fine, when the intention was to write: ```ts fromTemporaryCredentials({ ... clientConfig: { region, requestHandler: this.requestHandler, // type NodeHttpHandlerOptions }, }); ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information