Skip to content

refactor(devtools): use signals for template properties in frame manager #58818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor(devtools): use signals for template properties in frame manager #58818

wants to merge 2 commits into from

Conversation

sheikalthaf
Copy link
Contributor

convert the frames and selectedFrame properties to signal so that it can react to changes on OnPush

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dgp1130 November 22, 2024 08:50
@ngbot ngbot bot added this to the Backlog milestone Nov 22, 2024
@sheikalthaf
Copy link
Contributor Author

@dgp1130 can you review this PR, this is the final refactoring to mark components OnPush.

@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 5, 2024
dgp1130
dgp1130 reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR and apologies for the delay.

No major concerns on my end, just wondering if we can drop the angular-split usage in favor of more native CSS solutions.

I'll defer to @pkozlowski-opensource on the Signal<Map<...>> usage and whether this is the right direction or if a better solution exists.

@sheikalthaf
refactor(devtools): use signals for template properties in frame manager
20ff8f2 
convert the frames and selectedFrame properties to signal so that it can react to changes on OnPush
@sheikalthaf
refactor(devtools): add split to the demo devtools app
128f4e7 
added split area component to demo component so that we can resize the devtools and demo app.
dgp1130
dgp1130 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look @pkozlowski-opensource!

I'll mark this for merge but just FYI I think we're entering reduced caretaking for the holidays, so this might not be merged until January.

@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2024
thePunderWoman pushed a commit that referenced this pull request Jan 6, 2025
@sheikalthaf @thePunderWoman
refactor(devtools): use signals for template properties in frame mana…
57c826c 
…ger (#58818)

convert the frames and selectedFrame properties to signal so that it can react to changes on OnPush

PR Close #58818
thePunderWoman pushed a commit that referenced this pull request Jan 6, 2025
@sheikalthaf @thePunderWoman
refactor(devtools): add split to the demo devtools app (#58818)
b0ab674 
added split area component to demo component so that we can resize the devtools and demo app.

PR Close #58818
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 0bf6f76.

The changes were merged into the following branches: main, 19.0.x

thePunderWoman pushed a commit that referenced this pull request Jan 6, 2025
@sheikalthaf @thePunderWoman
refactor(devtools): add split to the demo devtools app (#58818)
0bf6f76 
added split area component to demo component so that we can resize the devtools and demo app.

PR Close #58818
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@sheikalthaf @PrajaktaB27
refactor(devtools): use signals for template properties in frame mana…
fb1b9f0 
…ger (angular#58818)

convert the frames and selectedFrame properties to signal so that it can react to changes on OnPush

PR Close angular#58818
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@sheikalthaf @PrajaktaB27
refactor(devtools): add split to the demo devtools app (angular#58818)
c32d029 
added split area component to demo component so that we can resize the devtools and demo app.

PR Close angular#58818
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@dgp1130 dgp1130 dgp1130 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@sheikalthaf @thePunderWoman @pkozlowski-opensource @dgp1130