refactor(docs-infra): cleanup after render sequence in ReferenceScrollHandler
#58640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: docs-infra
JeanMeche
reviewed
Nov 14, 2024
|
|
||
| // There's no reason to set this up on the server. | ||
| // It would also lead to a memory leak because we would need to | ||
| // remove the listener when the service is destroyed. |
There was a problem hiding this comment.
I'm wondering if we should rephrase this. ADEV doesn't rely on SSR but on SSG only. Memory-leak is somewhat a non-issue.
There was a problem hiding this comment.
I forgot about SSG-only. I updated the code with another small fix.
…llHandler` In this commit, we're replacing the provided injector in `afterNextRender` with a node injector because it was previously mistakenly passing an `EnvironmentInjector` in the `ReferenceScrollHandler`.
arturovt
force-pushed
the
refactor/docs-analytics
branch
from
3de0b5d
to
adf2c4b
Compare
arturovt
changed the title
error reporter only on clientReferenceScrollHandler
arturovt
changed the title
ReferenceScrollHandlerReferenceScrollHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we're replacing the provided injector in
afterNextRenderwith a node injectorbecause it was previously mistakenly passing an
EnvironmentInjectorin theReferenceScrollHandler.