Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NgOptimizedImage): Update the InputChanged error #58633

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(NgOptimizedImage): Update the InputChanged error #58633

wants to merge 3 commits into from

Conversation

tidusjar
Copy link

Update it to mention using @if rather than the *ngIf directive

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently it references using the *ngIf directive

Issue Number: N/A

What is the new behavior?

It will suggest to use the @if control flow block

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tidusjar
fix: Update the InputChanged error for the NgOptimizedImage
9c9cbf2 
Update it to mention using `@if` rather than the `*ngIf` directive
@google-cla Google CLA
Copy link

google-cla bot commented Nov 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thePunderWoman thePunderWoman added the area: common Issues related to APIs in the @angular/common package label Nov 13, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 13, 2024
@JoostK
Copy link
Member

JoostK commented Nov 13, 2024

I think it makes sense for this to be a refactor commit instead of fix, as there isn't really a bug being fixed here.

@tidusjar tidusjar changed the title fix(NgOptimizedImage): Update the InputChanged error refactor(NgOptimizedImage): Update the InputChanged error Nov 13, 2024
@AndrewKushnir
Copy link
Contributor

@tidusjar thanks for the update. I've noticed that you've updated the PR description, but the commit message remains the same. Could you please update the commit message as well (for example, using the git commit --amend command)? The commit message can be:

refactor(common): update the NgOptimizedImage message to use `@if` instead of `*ngIf`

This commit updates an error message to mention `@if` rather than the `*ngIf` directive.

tidusjar and others added 2 commits November 15, 2024 09:38
@tidusjar
refactor(common): update the NgOptimizedImage message to use @if in…
a1c9572 
…stead of `*ngIf`

This commit updates an error message to mention `@if` rather than the `*ngIf` directive.
@tidusjar
Merge branch 'patch-1' of https://github.com/tidusjar/angular into pa…
81c9851 
…tch-1
@JeanMeche
Copy link
Member

Can you make sur to drop that merge commit and squash the rest. We'd like this change to be a single commit. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: common Issues related to APIs in the @angular/common package
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@tidusjar @JoostK @AndrewKushnir @JeanMeche @thePunderWoman