Allow is_equal(0, -0) to be true to match === (bokeh#14038)

abdulrahman305 · Aug 23, 2024 · d0f895a · d0f895a
1 parent 496611f
commit d0f895a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bokehjs/src/lib/core/util/eq.ts b/bokehjs/src/lib/core/util/eq.ts
@@ -32,7 +32,7 @@ export class Comparator {
   }
 
   eq(a: any, b: any): boolean {
-    if (Object.is(a, b)) {
+    if (a === b || Object.is(a, b)) {
       return true
     }
 
@@ -127,7 +127,7 @@ export class Comparator {
   }
 
   numbers(a: number, b: number): boolean {
-    return Object.is(a, b)
+    return a === b || Object.is(a, b)
   }
 
   arrays(a: ArrayLike<unknown>, b: ArrayLike<unknown>): boolean {

diff --git a/bokehjs/test/unit/core/util/eq.ts b/bokehjs/test/unit/core/util/eq.ts
@@ -34,8 +34,8 @@ describe("core/util/eq module", () => {
   describe("implements is_equal() function", () => {
     it("that supports number type", () => {
       expect(is_equal(0, 0)).to.be.true
-      expect(is_equal(0, -0)).to.be.false
-      expect(is_equal(-0, 0)).to.be.false
+      expect(is_equal(0, -0)).to.be.true
+      expect(is_equal(-0, 0)).to.be.true
       expect(is_equal(-0, -0)).to.be.true
       expect(is_equal(0, 1)).to.be.false
       expect(is_equal(1, 0)).to.be.false