Draft: Implement streaming version of BytecodePolynomials
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is on the right track. I believe it should be fine that the final state isn't materialized until the stream is consumed, and I imagine doing so is more efficient than an additional pass upfront. That said, if it ends up being simpler to do the generate |
jprider63
force-pushed
the
feature/streaming_bytecode
branch
from
daca462
to
58992a5
Compare
jprider63
force-pushed
the
feature/streaming_bytecode
branch
from
c1554b2
to
534a79c
Compare
jprider63
force-pushed
the
feature/streaming_bytecode
branch
from
f81a384
to
a49f401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@moodlezoup @sragss, I've started implementing a streaming version of
BytecodePolynomials. I want to make sure we're on the right track before we start migrating the code to use this streaming behavior.I created the
MapStateiterator since the stream mutatesfinal_ctsas it processes the trace. It seems like this should exist in the standard library, but I couldn't find anything that accomplishes this. One limitation of this is thatfinal_ctscan't be read until the stream is consumed. I'm not sure if this is feasible with how the code usesfinal_cts. If not, we may need to do an additional pass upfront that computesfinal_cts.