-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better solution for scenario 1 #1311
Conversation
The third paragraph if scenario 1 is confusing and technically deficient. One cannot do ETL using the SQL endpoint in a lakehouse, which seems to be the intent. Here is my suggestion for a cleaner, more focused solution Susan would adopt.
@ArmandoLacerda : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 824ad9b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
The text in the rewritten paragraph convey many of the correct concepts, but do not make sense as written. Current text: Proposed text: |
@bradleyschacht 's version of the paragraph is way better than mine. Most important, it corrects the mistakes from the original paragraph, which is my intention. I vote to use the new proposed text by Bradley. |
Learn Build status updates of commit 5f9a17f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thanks, @bradleyschacht. I committed your suggestion. Important: When the changes are ready for publication, adding a |
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @bradleyschacht |
The third paragraph if scenario 1 is confusing and technically deficient. One cannot do ETL using the SQL endpoint in a lakehouse, which seems to be the intent. Here is my suggestion for a cleaner, more focused solution Susan would adopt.
Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.
Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.
For internal Microsoft contributors, check off these quality control items as you go
1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.
2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).
3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.
4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.
5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing
#sign-off
in a new comment in the Pull Request. If you need to cancel that sign-off, type#hold-off
instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.Merge and publish
#sign-off
, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.#sign-off
again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).