Skip to content

Conversation

@SimaoBolota-MetaCell
Copy link
Collaborator

@SimaoBolota-MetaCell SimaoBolota-MetaCell commented Nov 22, 2024

@SimaoBolota-MetaCell
Copy link
Collaborator Author

SimaoBolota-MetaCell commented Nov 22, 2024

@ddelpiano there seem to be issues on the sckan-qa pipeline that used to run the tests. Should I also check that?
https://g.codefresh.io/build/6740c25bbd1f8d66d8060966?activeAccountId=5ad732423645ac000112d7de&step=test_build&tab=output&logs=terminal

@SimaoBolota-MetaCell
Copy link
Collaborator Author

SimaoBolota-MetaCell commented Dec 12, 2024

@ddelpiano Fixed the qa pipeline so now it runs the tests in dev

https://g.codefresh.io/build/675ac2f6a41d4993c76ac430?activeAccountId=5ad732423645ac000112d7de

@SimaoBolota-MetaCell SimaoBolota-MetaCell marked this pull request as ready for review December 12, 2024 11:08
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimaoBolota-MetaCell I can see there have been changes to the package.json, could you please separate the testing dependencies in another package.json to keep in the test folder please?

I prefer do not impact the application dependencies for testing updates or upgrades we want to do with the libraries used for QA, and so separate them will keep them indipendent. Thanks.

@SimaoBolota-MetaCell SimaoBolota-MetaCell marked this pull request as ready for review January 2, 2025 10:38
# SECURITY WARNING: don't run with debug turned on in production!
PRODUCTION = os.environ.get("PRODUCTION", "False").lower() in ("true", "1")
USE_PG = os.environ.get("USE_PG", "False").lower() in ("true", "1")
TESTING = os.environ.get("TESTING", "False").lower() in ("true", "1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano ddelpiano merged commit 595d1d1 into develop Jan 8, 2025
1 check passed
@ddelpiano ddelpiano deleted the tests/SCKAN-287 branch March 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants