Draft: Legacy DXF importer: fix layer block behavior #18129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FreeCAD#16550. Fixes FreeCAD#16552. * Layer blocks receive a name with the "LayerBlock_" prefix. * They are put in a layer if the "Use layer" import option is checked. * If Draft or Sketch objects are created a Part_Compound instead of a Draft_Block is created. This was done because a Draft_Block does not claim its children. I am not sure about this change. Maybe the behavior of the Draft_Block should be changed instead. @yorikvanhavre: do you know why a Draft_Block does not claim its children?
2 tasks
That Draft Block object is very, very old... Maybe from a time before claimChildren() existed. IMHO we could think of obsoleting it, it's mostly redundant with part compounds... |
|
Let's merge then. |
Roy-043
deleted the
Draft-Legacy-DXF-importer-fix-layer-block-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16550.
Fixes #16552.
@yorikvanhavre: do you know why a Draft_Block does not claim its children?