Gui: allow LineEdit to grow with text - fixes #17747 #18099
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
FlachyJoe
reviewed
Nov 25, 2024
src/Gui/Tree.cpp
Outdated
Comment on lines
552
to
553
| int availableWidth = parentWidget()->width() - geometry().x() - 20; // Calculate available width | ||
| size.setWidth(std::min(fm.horizontalAdvance(text()) + 30, availableWidth)); // Add some padding and max width |
There was a problem hiding this comment.
Where are 20 and 30 come from?
There was a problem hiding this comment.
Some padding as to not overflow on the right, but might not be necessary.
I'll remove it and test.
There was a problem hiding this comment.
I changed the 30 to :
2 * (style()->pixelMetric(QStyle::PM_FocusFrameHMargin) + 1)
+ 2 * style()->pixelMetric(QStyle::PM_LayoutHorizontalSpacing)
+ TreeParams::getItemBackgroundPadding();I took inspiration from QRect TreeWidgetItemDelegate::calculateItemRect(), but I am not certain of what I did.
There was a problem hiding this comment.
@kadet1090 can you explain?
VincidaB
force-pushed
the
main
branch
4 times, most recently
from
c2c0249
to
54ca166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
DynamicQLineEditdynamic class for the model Tree so that the edit field can grow with what is being typed during renaming. This fixes #17747 .2024-11-23.16-58-11.mp4
I am not sure if this merits an new class or if it should have been added to
ExpLineEdit. (I didn't want to disturb the existing class).