Include missing eiconv implicit dependency from gen_smtp#662
Open
drobakowski wants to merge 2 commits intoChicagoBoss:masterfrom
Open
Include missing eiconv implicit dependency from gen_smtp#662drobakowski wants to merge 2 commits intoChicagoBoss:masterfrom
drobakowski wants to merge 2 commits intoChicagoBoss:masterfrom
Conversation
eiconv is declared as a testing dependency in gen_smtp and used from its MIME encoder/decoder, because of CB usage of the MIME decoder in boss_smtp_server / boss_mail_driver_mock it must be declared explicitly.
…_eiconv_dependency_upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eiconvis declared as a testing dependency in gen_smtp and used from its MIME encoder/decoder, because of CB usage of the MIME decoder inboss_smtp_server/boss_mail_driver_mockit must be declared explicitly.