Skip to content

Fix for correctly specifying priv directory#484

Open
graeme-defty wants to merge 1 commit intoChicagoBoss:masterfrom
graeme-defty:master
Open

Fix for correctly specifying priv directory#484
graeme-defty wants to merge 1 commit intoChicagoBoss:masterfrom
graeme-defty:master

Conversation

@graeme-defty
Copy link
Contributor

As described in email On Thu, Jul 3, 2014 at 5:30 AM

@choptastic
Copy link
Contributor

Thanks Graeme,

This will need some work in order to ensure that the tests pass - as this
little "../priv" was added because the tests required it. Before merging
this, I'd like to modify it to account for when the tests are running -
perhaps as a simple config variable, something like {priv_dir, "./priv"},
by default, and can be overriden.

It feels a little nasty, though, so I'll have to think about it when I
find the time.

-Jesse

On Sat, Jul 19, 2014 at 5:56 AM, graeme-defty [email protected]
wrote:

As described in email On Thu, Jul 3, 2014 at 5:30 AM

You can merge this Pull Request by running

git pull https://github.com/graeme-defty/ChicagoBoss master

Or view, comment on, or merge it at:

#484
Commit Summary

  • Fix for correctly specifying priv directory

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#484.

Jesse Gumm
Owner, Sigma Star Systems
414.940.4866 || sigma-star.com || @jessegumm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants