Skip to content

fix matrix multiplication error for MIRI focal plane features #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix matrix multiplication error for MIRI focal plane features #52

wants to merge 1 commit into from

Conversation

jordan-stone
Copy link

This pull request addresses the matrix multiplication error noted in issue #18

@pep8speaks
Copy link

Hello @jordan-stone, Thank you for submitting the Pull Request !

Line 22:1: E402 module level import not at top of file
Line 23:1: E402 module level import not at top of file
Line 25:1: E402 module level import not at top of file
Line 26:1: E402 module level import not at top of file
Line 27:1: E402 module level import not at top of file
Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 42:1: E402 module level import not at top of file
Line 43:1: E402 module level import not at top of file
Line 44:1: E402 module level import not at top of file
Line 100:8: E126 continuation line over-indented for hanging indent

If you have not done so, please consult the jwst_coronagraph_visibility Style Guide

@brynickson brynickson self-requested a review October 13, 2023 18:07
@brynickson brynickson linked an issue Oct 13, 2023 that may be closed by this pull request
possible bug or just confusion about rotation matrix in mask drawing #18
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynickson brynickson Awaiting requested review from brynickson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possible bug or just confusion about rotation matrix in mask drawing
2 participants
@jordan-stone @pep8speaks