[MISC] Nop reordering of Variant class.

smehringer · Nov 29, 2019 · 07ddbb1 · 07ddbb1
1 parent 248879a
commit 07ddbb1
Showing 1 changed file with 24 additions and 14 deletions.
diff --git a/include/sviper/variant.h b/include/sviper/variant.h
@@ -22,6 +22,14 @@ enum SV_TYPE
 
 struct Variant
 {
+    // Constructor, destructor, and assignment
+    // -------------------------------------------------------------------------
+    Variant() = default;
+    Variant(const Variant&) = default;
+    Variant(Variant&&) = default;
+    Variant& operator=(const Variant&) = default;
+    Variant& operator=(Variant&&) = default;
+
     Variant(const std::string & line)
     {
         std::stringstream ss(line);
@@ -136,20 +144,8 @@ struct Variant
         }
     }
 
-    void throw_verbose_exception(std::string const & what)
-    {
-        std::ostringstream os{};
-        os << what << "Read: ";
-        (*this).write(os);
-        throw std::iostream::failure(os.str());
-    }
-
-    Variant() = default;
-    Variant(const Variant&) = default;
-    Variant(Variant&&) = default;
-    Variant& operator=(const Variant&) = default;
-    Variant& operator=(Variant&&) = default;
-
+    // Member variables
+    // -------------------------------------------------------------------------
     SV_TYPE sv_type{};
     int     sv_length{-1};
     std::string  ref_chrom{};
@@ -164,6 +160,8 @@ struct Variant
     std::string  format{};
     std::vector<std::string>  samples{};
 
+    // Public Member Function
+    // -------------------------------------------------------------------------
     void write(std::ostream & stream)
     {
         stream << ref_chrom
@@ -179,6 +177,18 @@ struct Variant
             stream << "\t" << sample;
         stream << "\n";
     }
+
+private:
+    // Private functions
+    // -------------------------------------------------------------------------
+    // Make error messages more expressive by adding the full VCF record info
+    void throw_verbose_exception(std::string const & what)
+    {
+        std::ostringstream os{};
+        os << what << "Read: ";
+        (*this).write(os);
+        throw std::iostream::failure(os.str());
+    }
 };
 
 inline bool is_same_sv_type(char cigar_operation, SV_TYPE type)