chore: use mod.rs in db_cache #362
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
rodesai
reviewed
Nov 27, 2024
The linter was complaining about module inception otherwise. https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
dosubot
bot
added
size:XS
|
@flaneur2020 Took the liberty of updating this to get the tests passing. It involved two changes:
(2) had to be done to placate the linter (see the commit message for details). I know this means we have non-import logic in |
|
@criccomini sorry for delayed response due to business trip i think this pr is read to get merged after your appended commit 🙏, thank you for the help on this. |
AlvinKuruvilla
pushed a commit
to AlvinKuruvilla/slatedb
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #346 (comment)