Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue No #352] Fix --csv option doesn't escape newlines #361

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Issue No #352] Fix --csv option doesn't escape newlines #361

wants to merge 5 commits into from

Conversation

vishnuchilamakuru
Copy link

Fix --csv option doesn't escape newlines #352

  • Decode new line characters.
  • Comma is already handled by adding quotes in CSV for description field.
  • Add specs for decode_full_text method in utils.rb

@vishnuchilamakuru
Copy link
Author

Looks like Bundler issue for jruby 9.1.6.0 - rubygems/bundler#5202
For Ruby 2.3.3 - ku1ik/rainbow#48

These two builds are failing in travis because of these bugs. Had to change .travis.yml to fix these.

@githubbbie
Copy link

Hi, can this be applied @sferik and/or can you give some other contributors merge access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnuchilamakuru @githubbbie