text: Always resolve a font, fall back to an empty font #18814
+256
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simplifies code a bit and adds a message in case of panic.
This patch refactors code a bit and provides Font::empty_font which may be used to instantate a font without glyphs.
kjarosh
added
text
This makes code a lot easier and ensures there's always a font resolved to produce a proper text layout.
kjarosh
force-pushed
the
resolve-font
branch
3 times, most recently
from
9559c74
to
353e5e4
Compare
This test makes sure Ruffle does not panic when a default font is missing.
kjarosh
force-pushed
the
resolve-font
branch
from
353e5e4
to
354eb88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we always resolve some font, which is required for laying out text. When no font could be resolved, an empty font is returned that has no glyphs and has metrics with all values equal to 0.