web: On browsers which support it, specify the type of audio Ruffle uses #18752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
force-pushed
the
specify-audio-session
branch
from
86695c6 to
5e9dd6b
Compare
danielhjacobs
added
A-web
Member
|
Looks good, but wouldn't it make more sense to do this in the unmuteAudioContext() function? See also: #1552 |
Contributor
Author
|
Done, but I won't feel right merging this until someone with iOS 17+ tests it. |
danielhjacobs
force-pushed
the
specify-audio-session
branch
from
09456bd to
d963306
Compare
Contributor
Author
|
Can someone with iOS 16.4+ test https://danielhjacobs.github.io/ruffle-unmute-ios/ with the mute switch enabled and make sure it still plays audio. |
Contributor
Author
|
Tested and confirmed fixed by @CUB3D on Discord. |
danielhjacobs
force-pushed
the
specify-audio-session
branch
from
30df13e to
183fa41
Compare
CUB3D
approved these changes
Dec 1, 2024
Contributor
CUB3D
left a comment
CUB3D
left a comment
There was a problem hiding this comment.
Tested and confirmed working on iOS 16.6.1
Member
|
Also by a friend of mine on an iPhone with iOS 18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not tested this, but it may fix ruffle-rs/ruffle-rs.github.io#177.