Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FREELDR] Relocate itself if it's not at expected address #7530

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[FREELDR] Relocate itself if it's not at expected address #7530

wants to merge 8 commits into from
+444 −172

Conversation

iLauncherDev
Copy link
Contributor

@iLauncherDev iLauncherDev commented Nov 28, 2024 •
edited by HBelusca
Loading

Purpose

This PR has same purpose as #7501 but it works in Any Base Address(Aligned to 16 bytes) with 0x7C00 of minimum base address without any corruption.

JIRA issue: CORE-19882

Note

This PR will also help me with #7527 because it will decrease significantly the code difference.
I added some bonus commits in this PR.

@github-actions github-actions bot added the freeldr Freeloader changes label Nov 28, 2024
@iLauncherDev iLauncherDev changed the title [FREELDR] Relocate Freeldr if it's not in expected address [FREELDR] Relocate Freeldr if its not in expected address Nov 28, 2024
@binarymaster binarymaster added the enhancement For PRs with an enhancement/new feature. label Nov 28, 2024
@iLauncherDev iLauncherDev changed the title [FREELDR] Relocate Freeldr if its not in expected address [FREELDR] Relocate itself if its not in expected address Nov 28, 2024
iLauncherDev added a commit to iLauncherDev/reactos that referenced this pull request Nov 30, 2024
@iLauncherDev
[FREELDR] Add a missing break line in Msg_Unsupported from amd64.S (r…
91f9508 
…eactos#7530)
@HBelusca HBelusca changed the title [FREELDR] Relocate itself if its not in expected address [FREELDR] Relocate itself if it's not at expected address Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkreuzer tkreuzer Awaiting requested review from tkreuzer tkreuzer is a code owner

@Extravert-ir Extravert-ir Awaiting requested review from Extravert-ir Extravert-ir is a code owner

Assignees
No one assigned
Labels
enhancement For PRs with an enhancement/new feature. freeldr Freeloader changes
Projects
ReactOS PRs
Status: New PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLauncherDev @binarymaster