In principle this call shouldn't fail, but....

But does it matter for DIB_RGB_COLORS? It might be a palette thing?

@HBelusca, I did a non-exhaustive search of the ReactOS code base and in most cases where we use this code:

GetDC(NULL);

there is no error checking, but since you pointed this out, now I check if hDC is NULL.
If so, we will output an error message and skip the GetDIBits call that used this value.
We needed to free the iconinfo items, so we could not return here, but eventually after the failing "IF" test below, we will return "NULL".

@whindsaks, Sorry I do not understand your question about DIB_RGB_COLORS. Can you be more specific. Thanks.

My question was, does GetDIBits need a hdc with DIB_RGB_COLORS or is it only really needed for DIB_PAL_COLORS (palette).

@whindsaks, I do not really know the answer to your question, but it was a good one. In researching it, I found a much simpler way to get the width and height from an HBITMAP. So instead of using GetDIBits, I now use GetObject. So there is no longer any use of the DIB_PAL_COLORS of DIB_RGB_COLORS involved here. Thanks.