[SETUPLIB][REACTOS][USETUP] Turn setuplib into a DLL shared between TUI and GUI 1st-stage setups #7523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
requested review from
binarymaster,
ColinFinck,
cbialorucki,
DarkFire01,
hpoussin,
Doug-Lyons and
GeoB99
binarymaster
added
enhancement
binarymaster
approved these changes
Nov 23, 2024
|
Also maybe link to CORE-13525 in commit msg. |
HBelusca
added a commit
that referenced
this pull request
Nov 24, 2024
…UI and GUI 1st-stage setups (#7523) CORE-13525 Notes: - Most of the exported functions have been turned from default cdecl to explicit stdcall / "NTAPI". - The two phases of InitializeSetup() have been collapsed to make the initialization simpler.
HBelusca
force-pushed
the
hbelusca/setuplib_dll
branch
from
a47e3a1 to
8904243
Compare
HBelusca
added a commit
that referenced
this pull request
Dec 2, 2024
…UI and GUI 1st-stage setups (#7523) CORE-13525 Notes: - Most of the exported functions have been turned from default cdecl to explicit stdcall / "NTAPI". - The two phases of InitializeSetup() have been collapsed to make the initialization simpler.
HBelusca
force-pushed
the
hbelusca/setuplib_dll
branch
from
8904243 to
a91e230
Compare
HBelusca
added a commit
that referenced
this pull request
Dec 2, 2024
…UI and GUI 1st-stage setups (#7523) CORE-13525 Notes: - Most of the exported functions have been turned from default cdecl to explicit stdcall / "NTAPI". - The two InitializeSetup() phases have been collapsed to make the initialization simpler.
HBelusca
force-pushed
the
hbelusca/setuplib_dll
branch
from
a91e230 to
9b77c80
Compare
…UI and GUI 1st-stage setups (#7523) CORE-13525 Notes: - Most of the exported functions have been turned from default cdecl to explicit stdcall / "NTAPI". - The two InitializeSetup() phases have been collapsed to make the initialization simpler. Average reductions (percentages; see PR #7523 for actual numbers): x86 Debug builds: reactos.exe: 35.1% smss.exe : 39.8% Total (including setuplib.dll): 17.9% x86 Release builds: reactos.exe: 22.3% smss.exe : 25.0% Total (including setuplib.dll): 10.6% x64 Debug builds: reactos.exe: 40.6% smss.exe : 41.6% Total (including setuplib.dll): 20.0% x64 Release builds: reactos.exe: 22.8% smss.exe : 22.3% Total (including setuplib.dll): 10.1%
HBelusca
force-pushed
the
hbelusca/setuplib_dll
branch
from
9b77c80 to
d7c1d22
Compare
DarkFire01
added a commit
to DarkFire01/reactos
that referenced
this pull request
Dec 7, 2024
…etween TUI and GUI 1st-stage setups (reactos#7523)" This reverts commit d7c1d22.
DarkFire01
added a commit
to DarkFire01/reactos
that referenced
this pull request
Dec 8, 2024
…etween TUI and GUI 1st-stage setups (reactos#7523)" This reverts commit d7c1d22.
DarkFire01
added a commit
to DarkFire01/reactos
that referenced
this pull request
Dec 27, 2024
…etween TUI and GUI 1st-stage setups (reactos#7523)" This reverts commit d7c1d22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Turn setuplib into a DLL shared between TUI and GUI 1st-stage setups, so that the binaries (usetup.exe and the 1st-stage GUI reactos.exe setup) can share code.
NOTE: Since the setuplib itself is work-in-progress, some exported functions may change/be removed or added.
JIRA issue: CORE-13525
Observations
InitializeSetup()to make the initialization simpler.Sizes reductions
NOTE 1: All sizes are in bytes.
NOTE 2: "Before" is commit e51e5de.
NOTE 3:
% Reduction = 100 * (Before - After) / Beforegcc-i386-Debug-0x502
gcc-i386-Release-0x502
gcc-amd64-Debug-0x502
gcc-amd64-Release-0x502
msvc14.2-i386-Debug-0x502
msvc14.2-i386-Release-0x502
msvc14.2-amd64-Debug-0x502
msvc14.2-amd64-Release-0x502