Fix deprecated version compare from >= to >
#6850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6850 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 143 143
Lines 28190 28190
=======================================
Hits 27487 27487
Misses 703 703
|
|
@pyvista-bot LGTM |
pyvista-bot
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When releasing a new version, we need to update the version number to the next development version. For example, if we are releasing version 0.37.0, the next development version should be 0.38.0.dev0 which is greater than 0.37.0. This is why we need to check if the version is greater than 0.40.0 and 0.41.0 in the test code.
Details