Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov/codecov-action from 4 to 5 #6844

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2024

Bumps codecov/codecov-action from 4 to 5.

Release notes

Sourced from codecov/codecov-action's releases.

v5.0.0

v5 Release

v5 of the Codecov GitHub Action will use the Codecov Wrapper to encapsulate the CLI. This will help ensure that the Action gets updates quicker.

Migration Guide

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the Global Upload Token section of the settings page of an organization in codecov.io, you can set the ability for Codecov to receive a coverage reports from any source. This will allow contributors or other members of a repository to upload without needing access to the Codecov token. For more details see how to upload without a token.

[!WARNING]
The following arguments have been changed

  • file (this has been deprecated in favor of files)
  • plugin (this has been deprecated in favor of plugins)

The following arguments have been added:

  • binary
  • gcov_args
  • gcov_executable
  • gcov_ignore
  • gcov_include
  • report_type
  • skip_validation
  • swift_project

You can see their usage in the action.yml file.

What's Changed

... (truncated)

Changelog

Sourced from codecov/codecov-action's changelog.

v5 Release

v5 of the Codecov GitHub Action will use the Codecov Wrapper to encapsulate the CLI. This will help ensure that the Action gets updates quicker.

Migration Guide

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the Global Upload Token section of the settings page of an organization in codecov.io, you can set the ability for Codecov to receive a coverage reports from any source. This will allow contributors or other members of a repository to upload without needing access to the Codecov token. For more details see how to upload without a token.

[!WARNING] The following arguments have been changed

  • file (this has been deprecated in favor of files)
  • plugin (this has been deprecated in favor of plugins)

The following arguments have been added:

  • binary
  • gcov_args
  • gcov_executable
  • gcov_ignore
  • gcov_include
  • report_type
  • skip_validation
  • swift_project

You can see their usage in the action.yml file.

What's Changed

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from banesullivan as a code owner November 22, 2024 22:15
@dependabot dependabot bot added dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity labels Nov 22, 2024
@tkoyama010 tkoyama010 enabled auto-merge (squash) November 22, 2024 22:16
tkoyama010
tkoyama010 previously approved these changes Nov 22, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (7d7764f) to head (40522ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6844   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         143      143           
  Lines       28187    28187           
=======================================
  Hits        27484    27484           
  Misses        703      703           
---- 🚨 Try these New Features:

@pyvista-bot
Copy link
Contributor

pyvista-bot commented Nov 23, 2024

@pyvista-bot pyvista-bot temporarily deployed to pull request November 23, 2024 05:09 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request November 23, 2024 17:43 Inactive
@user27182 user27182 disabled auto-merge November 23, 2024 18:34
@user27182
Copy link
Contributor

This bump will need further action/review

@banesullivan
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 24, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@tkoyama010
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/github_actions/codecov/codecov-action-5 branch from d6759d3 to bf1eea4 Compare November 24, 2024 22:55
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/codecov/codecov-action-5 branch from bf1eea4 to c671e5a Compare November 29, 2024 04:16
@banesullivan
Copy link
Member

There are quite a few changes in the v5 release notes. I should be able to handle this

banesullivan
banesullivan previously approved these changes Nov 29, 2024
@banesullivan banesullivan enabled auto-merge (squash) November 29, 2024 07:34
@pyvista-bot pyvista-bot temporarily deployed to pull request November 29, 2024 09:24 Inactive
@banesullivan
Copy link
Member

I'm at a loss! Not sure why this is broken with the v5 upgrade? There's some sort of parsing error? 😕

@user27182
Copy link
Contributor

It seems there are a number of issues with this update. See codecov/codecov-action#1704 and codecov/codecov-action#1699. Both issues were opened within the last week, and emit the same parse error: Invalid numeric literal at line 1, column 10. Though, the exact cause in those cases seems to differ from our case (and I'm not able to see more detailed logs in CI).

Dependabot is also reporting only 71% compatibility (not great), might be best to wait for some upstream updates to this action.

@pyvista-bot pyvista-bot temporarily deployed to pull request November 29, 2024 23:59 Inactive
@banesullivan
Copy link
Member

I agree, lets just wait and see with this. I'm going to close this and have dependabot try again on the next release

@banesullivan
Copy link
Member

Actually, this isn't as simple as I hoped. Normally I could tell dependabot to ignore this minor version but there's just the major version identifier for actions. I'm going to leave this open and we can run @dependabot recreate in a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants