Skip to content

Add parameter annotations to geometric_objects.py #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

user27182
Copy link
Contributor

Overview

Some minor changes to variable names was required for some of the functions.

@pyvista-bot pyvista-bot added the maintenance Low-impact maintenance activity label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (e0945e7) to head (9c6600d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6838   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         143      143           
  Lines       28190    28190           
=======================================
  Hits        27487    27487           
  Misses        703      703           
---- 🚨 Try these New Features:

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 enabled auto-merge (squash) November 22, 2024 17:37
@pyvista-bot
Copy link
Contributor

pyvista-bot commented Nov 22, 2024

@pyvista-bot pyvista-bot temporarily deployed to pull request November 22, 2024 21:35 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request November 23, 2024 03:37 Inactive
@tkoyama010 tkoyama010 merged commit 7321c8f into main Nov 23, 2024
32 checks passed
@tkoyama010 tkoyama010 deleted the maint/geom-object-annotations branch November 23, 2024 22:34
@pyvista-bot pyvista-bot temporarily deployed to pull request November 23, 2024 23:57 Inactive
@banesullivan banesullivan mentioned this pull request Apr 17, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants