Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to glyph filter about geom direction assumption #6829

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

user27182
Copy link
Contributor

Overview

See #6823 (comment)

@pyvista-bot pyvista-bot added the documentation Anything related to the documentation/website label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (68adad5) to head (53ea811).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6829   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         144      144           
  Lines       28211    28211           
=======================================
  Hits        27508    27508           
  Misses        703      703           

@pyvista-bot
Copy link
Contributor

pyvista-bot commented Nov 21, 2024

@pyvista-bot pyvista-bot temporarily deployed to pull request November 21, 2024 19:30 Inactive
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot_20241122-053040

@pyvista-bot pyvista-bot temporarily deployed to pull request November 22, 2024 01:40 Inactive
@user27182 user27182 enabled auto-merge (squash) November 22, 2024 15:00
@pyvista-bot pyvista-bot temporarily deployed to pull request November 22, 2024 20:42 Inactive
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting until finish review.

Co-authored-by: user27182 <[email protected]>
@pyvista-bot pyvista-bot temporarily deployed to pull request November 26, 2024 15:13 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request November 27, 2024 06:25 Inactive
@tkoyama010 tkoyama010 enabled auto-merge (squash) November 27, 2024 06:51
@tkoyama010 tkoyama010 merged commit 8582f5e into main Nov 27, 2024
33 checks passed
@tkoyama010 tkoyama010 deleted the doc/glyph-note branch November 27, 2024 08:41
@pyvista-bot pyvista-bot temporarily deployed to pull request November 27, 2024 08:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants