Update typing for active array info and field association in dataset.py and arrays.py
#6822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6822 +/- ##
=======================================
Coverage 97.49% 97.50%
=======================================
Files 143 143
Lines 28181 28188 +7
=======================================
+ Hits 27476 27485 +9
+ Misses 705 703 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Most of the typing updates relate to
ActiveFieldInfoandFieldAssociation, though there are some other minor unrelated typing changes as well (e.g. magic methods).Also:
ActiveArrayInfo.__setitem__is removed (has no effect)ActiveArrayInfo.__getattr__is removed. This was an unnecessary "middle-man" that preventedmypyfrom being able to infer the type ofassociationandnameattributes.