Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point comparisons in test_axes_assembly.py #6806

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

user27182
Copy link
Contributor

Overview

Fix #6805 and related tests

@pyvista-bot pyvista-bot added the bug Uh-oh! Something isn't working as expected. label Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (fa6516a) to head (3361176).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6806   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         143      143           
  Lines       28178    28178           
=======================================
  Hits        27473    27473           
  Misses        705      705           
---- 🚨 Try these New Features:

@pyvista-bot
Copy link
Contributor

pyvista-bot commented Nov 18, 2024

@pyvista-bot pyvista-bot temporarily deployed to pull request November 18, 2024 02:34 Inactive
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 enabled auto-merge (squash) November 18, 2024 18:23
@pyvista-bot pyvista-bot temporarily deployed to pull request November 18, 2024 20:12 Inactive
@tkoyama010 tkoyama010 closed this Nov 18, 2024
auto-merge was automatically disabled November 18, 2024 22:07

Pull request was closed

@tkoyama010 tkoyama010 reopened this Nov 18, 2024
@tkoyama010 tkoyama010 enabled auto-merge (squash) November 18, 2024 22:08
@tkoyama010
Copy link
Member

Sorry. I closed the PR by mistake.

@tkoyama010 tkoyama010 merged commit 60be630 into main Nov 19, 2024
32 checks passed
@tkoyama010 tkoyama010 deleted the fix/float-equality branch November 19, 2024 01:57
@pyvista-bot pyvista-bot temporarily deployed to pull request November 19, 2024 01:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equality used to compare floating point numbers
3 participants