Move transformations from DataSet to DataSetFilters
#6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user27182
commented
Nov 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6799 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 143 143
Lines 28188 28187 -1
==========================================
- Hits 27485 27484 -1
Misses 703 703
|
|
Related issue on decoupling filters from datasets: |
akaszynski
previously approved these changes
Nov 20, 2024
tkoyama010
approved these changes
Nov 21, 2024
|
Just a heads up that since a few doc build images were removed by this PR, this messes up the build cache. So, all Documentation Build checks will now fail unless they use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have
DataSetFilters.transformandDataSetFilters.reflect, but all other transformation methods areDataSetmethods. This is inconsistent and confusing, especially since these methods pretty much all callDataSetFilters.transforminternally.This PR moves all methods to
DataSetFilters. Related tests are also moved.