-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always overwrite eigenvalues #1419
base: main
Are you sure you want to change the base?
Conversation
Can we merge this? |
It looks like the tests had been failing but the log doesn’t get shown, so I run them again with the latest version. If the tests pass, I think we can merge it. |
It looks like depending on the source the shape of the array is not the same. Do you want to look into it? @skatnagallu |
yep will do |
Pull Request Test Coverage Report for Build 10502979427Details
💛 - Coveralls |
I am not sure if the current failing Notebook has anything to do with this PR |
@skatnagallu I am rather sure it has:
|
Then I am not sure how to solve this. |
@samwaseda As far as I understand this pull request is no longer necessary after we merged #1549 , correct? If that is the case please close the pull request. |
It's true that what this was opened for got fulfilled, but the error of this PR showed another problem in the parser, so I would like to fix it before we forget about it -> leave it open for now, at least until next week |
Problem mentioned here