Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise HMGET method #2579

Merged

Conversation

JakubOnderka
Copy link
Contributor

Allocate output array to expected size and reuse already allocated string for output array keys

@JakubOnderka JakubOnderka force-pushed the redis_mbulk_reply_assoc branch 2 times, most recently from 02e843c to d80165b Compare November 24, 2024 22:25
@JakubOnderka JakubOnderka deleted the redis_mbulk_reply_assoc branch November 24, 2024 22:33
@JakubOnderka JakubOnderka restored the redis_mbulk_reply_assoc branch November 24, 2024 22:33
@JakubOnderka JakubOnderka reopened this Nov 24, 2024
Copy link
Member

@yatsukhnenko yatsukhnenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not duplicate z_keys cleanup code

library.c Outdated Show resolved Hide resolved
library.c Outdated Show resolved Hide resolved
library.c Outdated Show resolved Hide resolved
Allocate output array to expected size and reuse already allocated string for output array keys
@michael-grunder michael-grunder merged commit 2434ba2 into phpredis:develop Nov 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants