Use smart str for constructing pipeline cmd #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-grunder
approved these changes
Nov 25, 2024
| @@ -177,13 +177,7 @@ typedef enum { | |||
| #define IS_PIPELINE(redis_sock) (redis_sock->mode & PIPELINE) | |||
|
|
|||
| #define PIPELINE_ENQUEUE_COMMAND(cmd, cmd_len) do { \ | |||
There was a problem hiding this comment.
@michael-grunder we don't need this macro anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP's smart str provides easier API for appending new string and also do not need new allocation and deallocation for every command issued in pipeline like previously used zend_string.