-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Use epsg.io proj4 instead of proj4 from MapTiler API exports #16318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📦 Preview the website for this branch here: https://deploy-preview-16318--ol-site.netlify.app/. |
|
In addition to this change, I'd be in favor of depecating the |
|
The spatialreference definition for EPSG:27700 gives results very close to those for the most accurate non-grid transform if |
|
I do not think maintaining aliases may be necessary. Many of the WKT definitions place the datum code in in the GEOGCS name, not in the DATUM name (which holds a description). I found patching the following code from Proj.js to produces accurate results. Otherwise it falls back to WGS84, which in the case of EPSG:27700 is equivalent the tourist with GPS standing on the line at the Greenwich observatory. Ideally the WKT parser should set |
|
That's a bit of a hack. Better to enable looking up datums by the datum name, which proj4 v2.14 does. |
|
Hi, sorry for the inconvenience. We will fix the Coordinates API bug (returning default transformation |
138e6f0 to
33f3bb1
Compare
Done - proj4 v2.14 is required for |
|
Hi, the issue was solved on the MapTiler side. Now the |
Fixes #16244
This provide a workaround because the MapTiler API now longer exports more than the default transform. The MapTiler API continues to be required to determine the best compatible transform to use, but the transform id is then used to obtain the proj4 definition from epsg.io. This could be reverted if the MapTiler API reverts to its original behaviour.
Also rebased to use proj4 v2.14, changed
fromEPSGCodeto use spatialrefence.org, updated the example to use that, and deprecatedepsgLookupMapTiler.The example is working as expected https://deploy-preview-16318--ol-site.netlify.app/en/latest/examples/cog-projection.html