Only track pointers as touches if they have fired a POINTERDOWN event #16242
Conversation
|
📦 Preview the website for this branch here: https://deploy-preview-16242--ol-site.netlify.app/. |
|
Thanks for the fix! This might indeed interfere with the commented code section you mentioned. The problems related to that comment were reported with iOS and older Android devices. See #13771 for the list of associated issues. |
|
On the other hand, the only thing that could happen would be that a tracked pointer gets deleted on pointerup or pointercancel, so that should not matter. It would be good if you could add a test with the event sequence you reported in #16225, to make this pull request complete. |
|
Oh, I understand now what you probably meant. With your change, we might indeed be losing a drag sequence when the pointer id changes due to a target change. Unfortunately I was not able to reproduce the issues myself back then. |
|
Considering all this, I think a safer fix would be to separately track touch sequences pointerover - pointermove - pointerout with a separate tracked pointers object, and ignore these sequences. |
|
@pgorczak Would you be interested in finishing this according to my comment above? |
2 participants
This fixes #16225. Drag interactions now work on iPad without interference from the pencil hover-pointer.
I'm not sure about the comment above
openlayers/src/ol/MapBrowserEventHandler.js
Line 179 in dd1f3b7
This might constitute a case where we want to track a pointermove without a preceding pointerdown as a touch. Is there a known platform we can use to test against a possible regression?