Skip to content

Refactor WebGL Post-processing #16165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kikuchan wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor WebGL Post-processing #16165

kikuchan wants to merge 2 commits into from

Conversation

@kikuchan
Copy link
Contributor

@kikuchan kikuchan commented Sep 8, 2024

Try to solve the issue: #16120

Summary

  • Integrate PostProcessPass into the Helper.
  • Refactor PostProcessPass functions to use the Helper functions.
  • Manage textureSlot within the Helper and remove the slot argument from bindTexture.
  • postProcesses now accepts a callback function as a post-processor.
  • Adjust FlowLayer to adapt to the new callback style of postProcesses.

@kikuchan kikuchan force-pushed the refactor-webgl-postprocessing branch from 915b647 to a321ac2 Compare September 21, 2024 05:56
@github-actions
Copy link

github-actions bot commented Sep 21, 2024

📦 Preview the website for this branch here: https://deploy-preview-16165--ol-site.netlify.app/.

@kikuchan kikuchan mentioned this pull request Sep 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kikuchan