implement a string -> PackedTree parser
#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to moving the procedures, the generic interface (`fromSexp` and `fromSexpSym`) is changed such that no `SexpNode` or `PackedTree` is passed along to the procedures. This makes the interface more flexible, allowing it to be used in a context where no `SexpNode` or tree is available.
Parsing a string into an `SexpNode` tree first and then parsing said `SexpNode` tree into a `PackedTree` is unnecessarily wasteful. It's much more efficient to parse the string directly into a node sequence. The new parser is based on the existing `SexpParser`. It also doesn't use recursion, allowing it to parse arbitrarily nested S-expressions without causing a stack overflow.
The `phy` program can now parse the strings directly into a `PackedTree`, without needing an intermediate `SexpNode` parsing step. This should speed parsing up a bit.
saem
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a parser for
PackedTrees that operates directly on S-expressionstrings, without going through an intermediate
SexpNodetree.Details
move the existing
fromSexpprocedure fromtreestotree_parseradd the
parseSexpandfromSexpprocedures totree_parser, bothwhich take a
stringas the parameter. The parser reuses theexisting lexer/parser provided by
SexpParserchange the generic
fromSexpinterface procedure to take a typedvalue and
Literalsobject as input, instead of aSexpNodeandPackedTree, making them more generally applicableupdate the
fromSexpusages inphy.nim; first parsing an S-expression into a
SexpNode. This should speed up a parsing a littleNotes For Reviewers