Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh: Add final images for issues gallery #15600

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Refresh: Add final images for issues gallery #15600

merged 1 commit into from
Dec 2, 2024

Conversation

stephaniehobson
Copy link
Contributor

One-line summary

Add final issues gallery images #15307

Significant changes and points to review

  • image sizes match was is used in the ai gallery
    • however, both desktop and mobile are the same ratio so I combined the srcset and sizes
  • all images should be .jpg and optimized
  • alt text is not final so I did not wrap it for l10n
    • it's important to get feedback on what we have
    • we can make the display conditional on translation once we have them

Issue / Bugzilla link

#15307

Testing

Test at 1920, 1440, 1366, 1280, 1024, 768, 640, 360.
Test in both high and low res.

@stephaniehobson stephaniehobson requested a review from a team as a code owner November 28, 2024 17:02
@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: XS Code review time: up to 30min Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh labels Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (811948f) to head (6809e04).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15600      +/-   ##
==========================================
+ Coverage   79.00%   79.05%   +0.04%     
==========================================
  Files         158      159       +1     
  Lines        8303     8330      +27     
==========================================
+ Hits         6560     6585      +25     
- Misses       1743     1745       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wen-2018 wen-2018 self-assigned this Dec 2, 2024
@wen-2018 wen-2018 removed the Needs Review Awaiting code review label Dec 2, 2024
@wen-2018 wen-2018 merged commit 7207fc4 into main Dec 2, 2024
5 checks passed
@wen-2018 wen-2018 deleted the m24-issues-images branch December 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wen-2018 wen-2018 wen-2018 approved these changes

Assignees

@wen-2018 wen-2018

Labels
Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephaniehobson @wen-2018