Restrict base-uri in report-only CSP #15580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
No
<base href>
is being used around the site, so this makes sure no malicious code can tamper with relative links. (Once moved from report-only; this is to surface any potential issues first.)Significant changes and points to review
— Originally posted by @janbrasna in #15555 (comment):
Issue / Bugzilla link
#15555
Testing
This should have no impact on Wagtail previews, but please do test the CMS
experience is intact,usage doesn't trigger any base-uri violations, thanks! 😗To test this locally a couple of local env vars needs setting:
DEBUG=False
— CSP headers aren't added while in DEBUG modeCSP_RO_REPORT_URI=https://httpbin.org/post
— the report-only header is added only with any endpoint set