Fix invalid role on /leadership modal links (fixes #15538) #15539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P3
alexgibson
force-pushed
the
leadership-a11y
branch
from
314b64f
to
87ebba5
Compare
alexgibson
force-pushed
the
leadership-a11y
branch
from
87ebba5
to
90fb016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
<article>landmark to a regular<div>sinceroleis applied.aria-controlsandaria-expanded.Issue / Bugzilla link
#15538
Testing
I tested this with prod CMS data: https://bedrock.readthedocs.io/en/latest/cms.html#fetching-the-latest-cms-data-for-local-work
http://localhost:8000/en-US/about/leadership/
Running a11y tests should not generate a report for the leadership page after this fix:
npm startcd tests/playwrightnpm run a11y-testsI also tested this with VoiceOver on macOS to make sure things seemed to make sense.