fix loki-update label is not removed after the job #50607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxnddr
added
the
backport
kulyk
approved these changes
Nov 28, 2024
github-automation-metabase
added a commit
that referenced
this pull request
Nov 30, 2024
* fix loki-update label is not removed after the job * Update Loki Snapshots * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by: Metabase Automation <[email protected]>
github-automation-metabase
added a commit
that referenced
this pull request
Nov 30, 2024
* fix loki-update label is not removed after the job * Update Loki Snapshots * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by: Aleksandr Lesnenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
loki-updatelabel triggers a job that updates Loki snapshots and it should remove the label after completion, however, the label removal was broken so this PR fixes it.